Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish action goal status once accepted before execution. #1228

Merged
merged 1 commit into from
Feb 17, 2025
Merged

publish action goal status once accepted before execution. #1228

merged 1 commit into from
Feb 17, 2025

Conversation

fujitatomoya
Copy link
Collaborator

address #1072

fujitatomoya
fujitatomoya commented Feb 27, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment •
edited by wjwwood
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1072 (comment), it can publish the STATUS_ACCEPTED status.

### echo status topic
root@tomoyafujita:~/docker_ws/ros2_colcon# ros2 topic echo /fibonacci/_action/status --flow-style
status_list: [{goal_info: {goal_id: {uuid: [106, 201, 208, 38, 234, 228, 75, 98, 181, 133, 55, 213, 176, 209, 112, 205]}, stamp: {sec: 1709017655, nanosec: 488330228}}, status: 1}]
---
status_list: [{goal_info: {goal_id: {uuid: [106, 201, 208, 38, 234, 228, 75, 98, 181, 133, 55, 213, 176, 209, 112, 205]}, stamp: {sec: 1709017655, nanosec: 488330228}}, status: 2}]
---
status_list: [{goal_info: {goal_id: {uuid: [106, 201, 208, 38, 234, 228, 75, 98, 181, 133, 55, 213, 176, 209, 112, 205]}, stamp: {sec: 1709017655, nanosec: 488330228}}, status: 4}]
---

@fujitatomoya fujitatomoya requested a review from clalancette April 6, 2024 23:52
@fujitatomoya
Copy link
Collaborator Author

@clalancette @wjwwood friendly ping.

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/rclpy-issue-1072 branch from a8ace08 to dad57ec Compare February 6, 2025 01:18
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Feb 6, 2025 •
edited
Loading

Pulls: #1228
Gist: https://gist.githubusercontent.com/fujitatomoya/b2ff553d4440a50c13bd0f753bbfa6d9/raw/50af2339b6b531e8abdb1c6ebd7868ea16b60f92/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15127

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya requested a review from ahcorde February 14, 2025 22:50
@ahcorde ahcorde merged commit 87fbec0 into rolling Feb 17, 2025
3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/rclpy-issue-1072 branch February 17, 2025 08:57
@ahcorde
Copy link
Contributor

ahcorde commented Feb 17, 2025

@fujitatomoya any backports?

@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport jazzy humble

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025 •
edited
Loading

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 17, 2025
@fujitatomoya @mergify
publish action goal status once accepted before execution. (#1228)
48e8743 
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 87fbec0)
mergify bot pushed a commit that referenced this pull request Feb 17, 2025
@fujitatomoya @mergify
publish action goal status once accepted before execution. (#1228)
177e7d7 
Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 87fbec0)
This was referenced Feb 17, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@sloretz sloretz Awaiting requested review from sloretz

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @ahcorde @clalancette